Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gemstash compatibility added #7111

Closed
wants to merge 9 commits into from

Conversation

micheelengronne
Copy link

This PR adds a check to use the api/v1/dependencies.json endpoint if api/v1/versions does not exist.

It is currently the case for the Gemstash repository.

Closes #6787

@micheelengronne
Copy link
Author

prettier --list-different "**/*.{ts,js,mjs,json,md}" does not output anything. I don't know what to modify.

@rarkins
Copy link
Collaborator

rarkins commented Aug 27, 2020

Try running yarn lint locally.

But also, doesn't this solution try/fail for every dependency? i.e. if you need to look up 20 dependencies, it will result in 20 * 404 errors in addition to the 200 * 200 OK?

@micheelengronne
Copy link
Author

Indeed. But a Gemfile can contain gems from multiple sources. We canno't know in advance if the gem can be fetched from api/v1/versions or not.

I will do more tests locally as the unit tests broke.

@rarkins
Copy link
Collaborator

rarkins commented Aug 27, 2020

I'd wondered if we could detect when a particular registryUrl does not support the traditional endpoint and then "remember" that for subsequent requests

@micheelengronne
Copy link
Author

Maybe via a hostRules settings ?

@rarkins
Copy link
Collaborator

rarkins commented Aug 27, 2020

I think it's ok to try/fail but I prefer we only do it once per run instead of once per dependency.

@rarkins rarkins marked this pull request as draft December 4, 2020 06:26
@rarkins rarkins closed this Jul 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemstash server integration
2 participants